Skip to content

fix: resolve null room check and broken reply name uniqueness validation#71

Closed
sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
sezallagwal:fix/contextual-bar-actions-null-room
Closed

fix: resolve null room check and broken reply name uniqueness validation#71
sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
sezallagwal:fix/contextual-bar-actions-null-room

Conversation

@sezallagwal
Copy link
Contributor

Closes #70

Changes

  • src/handlers/ExecuteBlockActionHandler.ts:

    • Changed room === undefined to !room to handle both null and undefined
    • Replaced console.error with this.app.getLogger().error() for proper logging
  • src/storage/ReplyStorage.ts:

    • Changed replyFound.id === replyId; return true; to return replyFound.id === replyId;

Testing

Bug 1

  1. Run /quick list in any channel
  2. Click the overflow menu (⋮) on any reply
  3. Verify Send → opens send modal
  4. Verify Edit → opens edit modal
  5. Verify Delete → opens delete confirmation

Bug 2

  1. Create two replies with different names
  2. Edit one and change its name to match the other
  3. Verify an error is shown and the edit is rejected

##Demo

Recording.2026-03-17.173635.mp4

@not-meet
Copy link
Contributor

hey @sezallagwal ig there is a open pr and bug report for the resolve null room check bug in contextual bar #67 !
do reffer it once

@iam-vipin iam-vipin closed this Mar 21, 2026
@iam-vipin
Copy link
Collaborator

Hey @sezallagwal Closing this PR since its already fixed

@sezallagwal
Copy link
Contributor Author

Hey @iam-vipin, this PR also fixes Bug 2 from #70, the broken duplicate name validation in ReplyStorage.ts (It allows duplicate reply names when editing). That bug is still unresolved. Should I open a new PR for that fix or reopen this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Contextual bar actions do not work and duplicate reply names are allowed during edits

3 participants