fix: resolve null room check and broken reply name uniqueness validation#71
Closed
sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
Closed
fix: resolve null room check and broken reply name uniqueness validation#71sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
sezallagwal wants to merge 1 commit intoRocketChat:mainfrom
Conversation
Contributor
|
hey @sezallagwal ig there is a open pr and bug report for the resolve null room check bug in contextual bar #67 ! |
Collaborator
|
Hey @sezallagwal Closing this PR since its already fixed |
Contributor
Author
|
Hey @iam-vipin, this PR also fixes Bug 2 from #70, the broken duplicate name validation in ReplyStorage.ts (It allows duplicate reply names when editing). That bug is still unresolved. Should I open a new PR for that fix or reopen this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
Changes
src/handlers/ExecuteBlockActionHandler.ts:room === undefinedto!roomto handle bothnullandundefinedconsole.errorwiththis.app.getLogger().error()for proper loggingsrc/storage/ReplyStorage.ts:replyFound.id === replyId; return true;toreturn replyFound.id === replyId;Testing
Bug 1
/quick listin any channelBug 2
##Demo
Recording.2026-03-17.173635.mp4