Adding generator_stop to compile_future_features#5320
Merged
youknowone merged 3 commits intoRustPython:mainfrom May 13, 2024
Merged
Adding generator_stop to compile_future_features#5320youknowone merged 3 commits intoRustPython:mainfrom
youknowone merged 3 commits intoRustPython:mainfrom
Conversation
matheusfgoncalves95
force-pushed
the
generator-stop
branch
from
5e5a905 to
26c1757
Compare
matheusfgoncalves95
force-pushed
the
generator-stop
branch
from
26c1757 to
888d975
Compare
fanninpm
reviewed
May 13, 2024
compiler/codegen/src/compile.rs
Outdated
Comment on lines
+2913
to
+2914
| | "compile_future_features" => {} | ||
| "generator_stop" => {} |
Contributor
There was a problem hiding this comment.
Does this work?
Suggested change
| | "compile_future_features" => {} | |
| "generator_stop" => {} | |
| | "compile_future_features" | |
| | "generator_stop" => {} |
Contributor
Author
There was a problem hiding this comment.
Oops, my autoformatter led to that silly mistake. I also somehow introduced compile_future_features there!
To answer your question: it seems to work.
I did a quick check on the Python interpreter and the import succeeds. The module also looks okay via dir() inspection.
Anyhow, I will fix it. Thanks for pointing that out.
matheusfgoncalves95
force-pushed
the
generator-stop
branch
from
7b94f23 to
28f407b
Compare
youknowone
requested changes
May 13, 2024
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Thank you for contributing! Your patch also fixed a test in test_contextlib. Could you also update the test? Removing @unittest.expectedFailure will fix the CI failure
youknowone
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As well as some mild formatting.
Fix #4060