Added xcprivacy manifest to CocoaPods#3649
Merged
dreampiggy merged 3 commits intoSDWebImage:masterfrom Dec 8, 2023
Merged
Conversation
Using the resource bundle syntax
Added xcprivacy for CocoaPods
dreampiggy
force-pushed
the
feat/cocoapods_xcprivacy
branch
from
4700a71 to
1186e50
Compare
aboedo
pushed a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Mar 26, 2024
### Motivation The library already includes Privacy.xcprivacy in SPM, but when used with CocoaPods (mandatory in Flutter), these files are not exported as the podspec does not include that file as a resource bundle. ### Description Listing the PrivacyInfo.xcprivacy file inside the resource_bundles specification in the podspec allows to distribute the file correctly. Ref. CocoaPods/CocoaPods#10325 (comment) This GitHub issue contains the entire discussion on how to add these xcprivacy files and is referenced in multiple places; many libraries already follow this approach: https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseCrashlytics.podspec SDWebImage/SDWebImage#3649 flutter/packages#5846 Baseflow/flutter-permission-handler#1291 Baseflow/flutter-geolocator#1462
aboedo
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Mar 27, 2024
#3775) ### Motivation The library already includes Privacy.xcprivacy in SPM, but when used with CocoaPods (mandatory in Flutter), these files are not exported as the podspec does not include that file as a resource bundle. ### Description Listing the PrivacyInfo.xcprivacy file inside the resource_bundles specification in the podspec allows to distribute the file correctly. Ref. CocoaPods/CocoaPods#10325 (comment) This GitHub issue contains the entire discussion on how to add these xcprivacy files and is referenced in multiple places; many libraries already follow this approach: https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseCrashlytics.podspec SDWebImage/SDWebImage#3649 flutter/packages#5846 Baseflow/flutter-permission-handler#1291 Baseflow/flutter-geolocator#1462 Co-authored-by: Sergio Durban Belmonte <[email protected]>
|
@dreampiggy SDWebImage 5.19.1 from CP does not seem to include the privacy info file in the project, neither ship it in the bundled framework 🤔 
|
|
I just realized what's wrong here. The app was only indirectly fetching SDWebImage/Core, not the full podspec. Thus the resources folder was missing. |
Contributor
Author
Seems CocoaPods bug... It ignore the root spec resource bundle... |
Contributor
Author
|
I can move this into SDWebImage/Core ? |
Contributor
Author
|
Acutally, if you use pod "SDWebImage", it actually integrates only "SDWebImage/Core" and the resource bundle contains privacy file |
|
This is the diff from the previous setup (indirectly adding SDWebImage) and the one where CP does add the Privacy resource. Not sure if it's a CP bug or expected behavior, as the lib require only the Core subspec 
|
hellocake
pushed a commit
to hellocake/SDWebImage
that referenced
this pull request
Dec 31, 2024
* Added xcprivacy manifest to CocoaPods Using the resource bundle syntax * Update the README Added xcprivacy for CocoaPods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
Using the resource bundle syntax
See: CocoaPods/CocoaPods#10325
Should work when using CocoaPods with
use_frameworks! :linkage => what_ever