Create a custom MediaRouter for screenshot tests and add new screenshot tests#65
Merged
Create a custom MediaRouter for screenshot tests and add new screenshot tests#65
MediaRouter for screenshot tests and add new screenshot tests#65Conversation
Code Coverage
|
MGaetan89
force-pushed
the
RouteInfo_screenshots
branch
from
043be6c to
a10ab27
Compare
StaehliJ
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR creates
ScreenshotMediaRouteProviderandScreenshotMediaRouterto help generate screenshots without relying on the platformMediaRoutersystem service.It also adds new screenshot tests to help work on #58.
Changes made
ScreenshotMediaRouteProviderto provide some sample routes in screenshots.ScreenshotMediaRouteras an alternative toMediaRouterin screenshots.MediaRouteChooserDialogScreenshotto use the newScreenshotMediaRouter.MediaRouteControllerDialog.MediaRouteControllerDialog.