Skip to content

Display the playlist on the TV demo#1020

Merged
MGaetan89 merged 1 commit intomainfrom
display_playlist_demo_tv
May 12, 2025
Merged

Display the playlist on the TV demo#1020
MGaetan89 merged 1 commit intomainfrom
display_playlist_demo_tv

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented May 9, 2025

Pull request

Description

This PR adds a new button to the player view in pillarbox-demo-tv to view the playlist being played. Additional features (add, remove, sort) will come in dedicated PRs.

Changes made

  • Small refactoring of the existing player drawer so it can support two modes: settings and playlist.
  • Add a button to the player view to open the playlist drawer.
  • Remove the explicit Application argument of the PlayerSettingsViewModel.Factory().

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this May 9, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 9, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems May 9, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 9, 2025 •
edited
Loading

Code Coverage

Overall Project 50.72% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 force-pushed the display_playlist_demo_tv branch from fe16e40 to c8438d3 Compare May 9, 2025 10:14
@MGaetan89 MGaetan89 marked this pull request as ready for review May 9, 2025 10:15
@MGaetan89 MGaetan89 requested a review from StaehliJ May 9, 2025 10:15
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🍿 Code Review in Pillarbox May 9, 2025
@MGaetan89 MGaetan89 force-pushed the display_playlist_demo_tv branch 2 times, most recently from 149688d to 94c28a4 Compare May 12, 2025 05:32
@MGaetan89 MGaetan89 force-pushed the display_playlist_demo_tv branch from 94c28a4 to e0f4cea Compare May 12, 2025 06:17
@MGaetan89 MGaetan89 added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 431e5c5 May 12, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the display_playlist_demo_tv branch May 12, 2025 12:43
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox May 12, 2025
@MGaetan89 MGaetan89 mentioned this pull request May 9, 2025
Closed
3 tasks
@MGaetan89 MGaetan89 linked an issue May 12, 2025 that may be closed by this pull request
Add simple playlist management to the demo tv player #1019
Closed
3 tasks
@MGaetan89 MGaetan89 modified the milestones: Demo, TV May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

TV

Development

Successfully merging this pull request may close these issues.

Add simple playlist management to the demo tv player

2 participants

@MGaetan89 @StaehliJ