Skip to content

Add Chapter type and get chapters only for Type.EPISODE#1031

Merged
StaehliJ merged 5 commits intomainfrom
1026-remove-segments-for-livestreams
May 19, 2025
Merged

Add Chapter type and get chapters only for Type.EPISODE#1031
StaehliJ merged 5 commits intomainfrom
1026-remove-segments-for-livestreams

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented May 13, 2025 •
edited
Loading

Pull request

Description

Segment for live streams are not parse anymore. SRGSSR/pillarbox-documentation#145 (comment)

Changes made

  • Parse Chapter.type to know the kind of chapter.
  • Chapters are parsed only for Chapter.type of Type.EPISODE.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue May 13, 2025 that may be closed by this pull request
Remove segments for livestreams #1026
Closed
1 task
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 13, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 May 13, 2025 15:05
@github-actions
Copy link

github-actions bot commented May 14, 2025 •
edited
Loading

Code Coverage

Overall Project 50.8% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-core-business 78.15% 🟢
Files
Module File Coverage
:pillarbox-core-business ChapterAdapter.kt 100% 🟢
Type.kt 100% 🟢
Chapter.kt 59.03% 🟢

@StaehliJ
Copy link
Contributor Author

StaehliJ commented May 16, 2025

I updated this PR to match our latest discussion about that topic. SRGSSR/pillarbox-documentation#146 (comment)

@StaehliJ StaehliJ changed the title Add Chapter type to filter chapter for live streams Add Chapter type and filter chapters only for Type.EPISODE May 16, 2025
@StaehliJ StaehliJ changed the title Add Chapter type and filter chapters only for Type.EPISODE Add Chapter type and filter chapters only for Type.EPISODE May 16, 2025
@StaehliJ StaehliJ changed the title Add Chapter type and filter chapters only for Type.EPISODE Add Chapter type and get chapters only for Type.EPISODE May 16, 2025
@StaehliJ @MGaetan89
Update pillarbox-core-business/src/test/java/ch/srgssr/pillarbox/core…
b9812c5 
…/business/ChapterAdapterTest.kt

Co-authored-by: Gaëtan Muller <[email protected]>
@StaehliJ StaehliJ enabled auto-merge May 19, 2025 06:33
@StaehliJ StaehliJ added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit e0d62f5 May 19, 2025
10 checks passed
@StaehliJ StaehliJ deleted the 1026-remove-segments-for-livestreams branch May 19, 2025 06:40
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove segments for livestreams

2 participants

@StaehliJ @MGaetan89