Skip to content

Edit playlist in the TV demo#1032

Merged
MGaetan89 merged 4 commits intomainfrom
edit_playlist_demo_tv
May 19, 2025
Merged

Edit playlist in the TV demo#1032
MGaetan89 merged 4 commits intomainfrom
edit_playlist_demo_tv

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented May 14, 2025 •
edited
Loading

Pull request

Description

This PR adds the ability to modify the playlist from the TV demo. In particular, it allows adding and removing items from the playlist.

Changes made

  • Add a new playlist edition screen:
    • Add a single item.
    • Add all items at once.
    • Remove a single item.
    • Remove all items at once.
  • Create a new DrawerContent composable for the TV demo.

Screenshots

Description Screenshot
Playlist content Screenshot_20250515_142202
Playlist edition Screenshot_20250515_142222

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this May 14, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 14, 2025
@MGaetan89 MGaetan89 assigned MGaetan89 and unassigned MGaetan89 May 14, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox May 14, 2025
@MGaetan89 MGaetan89 added this to the Demo milestone May 14, 2025
@MGaetan89 MGaetan89 mentioned this pull request May 12, 2025
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented May 14, 2025 •
edited
Loading

Code Coverage

Overall Project 50.8% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 requested a review from StaehliJ May 14, 2025 15:44
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox May 14, 2025
@MGaetan89 MGaetan89 linked an issue May 15, 2025 that may be closed by this pull request
Add simple playlist management to the demo tv player #1019
Closed
3 tasks
@MGaetan89 MGaetan89 modified the milestones: Demo, TV May 15, 2025
StaehliJ
StaehliJ reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that you can edit only item added by the UI? For exemple if we want to remove the first item played that is not part of the available playlist item?

@MGaetan89
Copy link
Contributor Author

MGaetan89 commented May 16, 2025

Is it normal that you can edit only item added by the UI? For exemple if we want to remove the first item played that is not part of the available playlist item?

@StaehliJ it should be good now

@MGaetan89 MGaetan89 added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 2f3df3f May 19, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the edit_playlist_demo_tv branch May 19, 2025 08:54
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

TV

Development

Successfully merging this pull request may close these issues.

Add simple playlist management to the demo tv player

2 participants

@MGaetan89 @StaehliJ