Skip to content

Use non-deprecated methods#1034

Merged
StaehliJ merged 1 commit intomainfrom
fix-update-media3-1-6
May 20, 2025
Merged

Use non-deprecated methods#1034
StaehliJ merged 1 commit intomainfrom
fix-update-media3-1-6

Conversation

@StaehliJ
Copy link
Contributor

Pull request

Description

Stop using depreciated methods. TrackSelectionParameters doesn't needs Context.

What can we do with the setPreferredAudioRoleFlagsToAccessibilityManagerSettings ? It is very complicated to enhanced a custom TrackSelector with a custom TrackSelectionParameters.

Changes made

  • Remove Context parameters where needed

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 15, 2025
@MGaetan89 MGaetan89 changed the title Use none depreciated methods Use none deprecated methods May 16, 2025
@MGaetan89 MGaetan89 changed the title Use none deprecated methods Use non-deprecated methods May 16, 2025
@StaehliJ StaehliJ moved this from 📋 Backlog to 🍿 Code Review in Pillarbox May 19, 2025
@StaehliJ StaehliJ enabled auto-merge May 19, 2025 06:41
@github-actions
Copy link

Code Coverage

Overall Project 50.7% -0.03% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-player 57.13% -0.06% 🟢
Files
Module File Coverage
:pillarbox-player TrackSelectionParameters.kt 1.47% -0.37% 🟢
PlayerExtensions.kt 0% -8.6% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit b3d7a9e May 20, 2025
34 of 38 checks passed
@StaehliJ StaehliJ deleted the fix-update-media3-1-6 branch May 20, 2025 06:42
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox May 20, 2025
@MGaetan89 MGaetan89 mentioned this pull request May 20, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants