Skip to content

Fix deprecations#1041

Merged
StaehliJ merged 1 commit intomainfrom
fix_deprecations
May 21, 2025
Merged

Fix deprecations#1041
StaehliJ merged 1 commit intomainfrom
fix_deprecations

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

This PR follows-up on #1034 to fix a couple more deprecations.

Changes made

  • Use the TrackSelectionParameters.Builder() constructor that does not require a Context.
  • Override the AnalyticsListener's onLoadStarted() method that takes a retryCount: Int argument.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this May 20, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 20, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox May 20, 2025
@github-actions
Copy link

github-actions bot commented May 20, 2025

Code Coverage

Overall Project 50.8% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 57.11% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxTrackSelector.kt 100% 🟢
PlaybackSessionManager.kt 92.97% 🟢
Monitoring.kt 88.73% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ May 20, 2025 07:13
@MGaetan89 MGaetan89 marked this pull request as ready for review May 20, 2025 07:13
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox May 20, 2025
@StaehliJ StaehliJ added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 402a0b4 May 21, 2025
16 of 17 checks passed
@StaehliJ StaehliJ deleted the fix_deprecations branch May 21, 2025 07:22
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants