Skip to content

Improve service#1042

Merged
MGaetan89 merged 3 commits intomainfrom
improve-service
May 23, 2025
Merged

Improve service#1042
MGaetan89 merged 3 commits intomainfrom
improve-service

Conversation

@StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to use default task removing from Android instead of handle it inside the customs Pillarbox classes.

Integrators have to update the service definition inside the manifest with android:stopWithTask="true"

Changes made

  • Add showcase that use a MediaSessionService.
  • Remove onTaskRemoved that can be configured inside the manifest.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-actions
Copy link

github-actions bot commented May 21, 2025

Code Coverage

Overall Project 50.86% -0.01% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-player 57.24% -0.03% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxMediaSessionService.kt 0% -1.9% 🟢
PillarboxMediaLibraryService.kt 0% -2% 🟢

Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻
I've just pushed some small changes in b808530

@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🍿 Code Review in Pillarbox May 21, 2025
@StaehliJ StaehliJ added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit f3f3840 May 23, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the improve-service branch May 23, 2025 14:16
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants