Skip to content

Rework the playlist view on mobile#1043

Merged
MGaetan89 merged 2 commits intomainfrom
275-demo-playlist-view-item-can-be-draggable-2
May 23, 2025
Merged

Rework the playlist view on mobile#1043
MGaetan89 merged 2 commits intomainfrom
275-demo-playlist-view-item-can-be-draggable-2

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

This PR adds the ability to drag&drop items in the playlist view and updates its design.

Changes made

  • Add the reorderable dependency to support drag&drop in a lazy collection.
  • Update PlaylistView:
    • Support drag&drop to reorder items in the list.
    • Support swipe on an item to remove it from the list.
    • Move the playlist commands (add, shuffle, remove all) in a floating toolbar.
    • Improve the empty state layout by hiding unnecessary features (i.e. remove all, shuffle).
  • Update MediaItemLibraryDialog to use less custom components.

Screenshots

Description Dark mode Light mode
Empty state Screenshot_20250522_153442 Screenshot_20250522_153513
Playlist Screenshot_20250522_153936 Screenshot_20250522_153944
Add to playlist Screenshot_20250522_153503 Screenshot_20250522_153530

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this May 22, 2025
@MGaetan89 MGaetan89 linked an issue May 22, 2025 that may be closed by this pull request
1 task
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 22, 2025
@MGaetan89 MGaetan89 force-pushed the 275-demo-playlist-view-item-can-be-draggable-2 branch from cfac6fb to c264587 Compare May 22, 2025 13:43
@github-actions
Copy link

Code Coverage

Overall Project 50.8% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 requested a review from StaehliJ May 22, 2025 13:53
@MGaetan89 MGaetan89 marked this pull request as ready for review May 22, 2025 13:54
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could improve visually the items that is dragged. The changes are good to me.

@MGaetan89 MGaetan89 added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit ed82565 May 23, 2025
16 of 17 checks passed
@MGaetan89 MGaetan89 deleted the 275-demo-playlist-view-item-can-be-draggable-2 branch May 23, 2025 14:15
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Demo playlist view item can be draggable

2 participants