Skip to content

Integrate shuffle/repeat modes inside the demo player#1044

Merged
MGaetan89 merged 1 commit intomainfrom
integrate_shuffle_repeat_player
May 26, 2025
Merged

Integrate shuffle/repeat modes inside the demo player#1044
MGaetan89 merged 1 commit intomainfrom
integrate_shuffle_repeat_player

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

This PR integrates the shuffle and repeat modes inside the demo player toolbar.

Changes made

  • Update the demo player toolbar to optionally display shuffle and repeat buttons.
  • Remove the shuffle button from the playlist view.
  • Update the playlist view to display the "Add" and "Remove all" buttons as FABs.
  • Remove the repeat mode toggle from CustomPlaybackSettingsShowcase.
  • Add a new Player.repeatModeAsFlow().
  • Add a new Player.Commands.canSetShuffleMode().
  • Add a new Player.Commands.canSetRepeatMode().
  • Add a new Player.repeatModeAsState().

Screenshots

Description Dark mode Light mode
Playlist view Screenshot_20250523_162751 Screenshot_20250523_162806
CustomPlaybackSettingsShowcase Screenshot_20250523_162828 Screenshot_20250523_162837

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this May 23, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox May 23, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox May 23, 2025
@MGaetan89 MGaetan89 added this to the Demo milestone May 23, 2025
@github-actions
Copy link

Code Coverage

Overall Project 50.89% -0.1% 🟢
Files changed 60.26% 🟢

Module Coverage
:pillarbox-player 57.39% 🟢
:pillarbox-ui 0.27% -0.65% 🟢
Files
Module File Coverage
:pillarbox-player PlayerCommands.kt 100% 🟢
PlayerCallbackFlow.kt 70.08% 🟢
:pillarbox-ui ComposablePlayer.kt 0% -4.09% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ May 23, 2025 14:34
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox May 23, 2025
@MGaetan89 MGaetan89 marked this pull request as ready for review May 23, 2025 14:34
@MGaetan89 MGaetan89 added this pull request to the merge queue May 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 26, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue May 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 26, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit d689d0f May 26, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the integrate_shuffle_repeat_player branch May 26, 2025 07:59
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants