Skip to content

1049 playbackmetrics is available through pillarboxplayer interface#1072

Merged
MGaetan89 merged 8 commits intomainfrom
1049-playbackmetrics-is-available-through-pillarboxplayer-interface
Jun 20, 2025
Merged

1049 playbackmetrics is available through pillarboxplayer interface#1072
MGaetan89 merged 8 commits intomainfrom
1049-playbackmetrics-is-available-through-pillarboxplayer-interface

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jun 18, 2025

Pull request

Description

Add metrics related data available through the base interface. It allow PillarboxMediaController to display metrics. When a implementation doesn't have playback metrics, the field PillarboxPlayer.isMetricsAvailable should return false.

Changes made

  • Add PillarboxPlayer.getCurrentMetrics to PillarboxPlayer interface.
  • Add PillarboxPlayer.isMetricsAvailable to PillarboxPlayer interface.
  • PillarboxMediaController can now get the current PlaybackMetrics.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Jun 18, 2025 that may be closed by this pull request
PlaybackMetrics is available through PillarboxPlayer interface #1049
Closed
2 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jun 18, 2025
@github-actions
Copy link

github-actions bot commented Jun 18, 2025 •
edited
Loading

Code Coverage

Overall Project 50.18% -1.9% 🟢
Files changed 3.21% 🟢

Module Coverage
:pillarbox-player 56.09% -3.62% 🟢
:pillarbox-cast 8.42% -0.2% 🟢
:pillarbox-ui 0.27% -0.38% 🟢
Files
Module File Coverage
:pillarbox-player PlaybackMetrics.kt 76.77% -21.21% 🟢
PillarboxExoPlayer.kt 70.99% 🟢
PlayerCallbackFlow.kt 70.08% -0.52% 🟢
PillarboxPlayer.kt 0% -69.23% 🟢
PillarboxSessionCommands.kt 0% 🟢
PillarboxMediaController.kt 0% -14.17% 🟢
PillarboxMediaSession.kt 0% -26.01% 🟢
:pillarbox-cast PillarboxCastPlayer.kt 0% -0.4% 🟢
:pillarbox-ui ComposablePlayer.kt 0% -2.37% 🟢

@MGaetan89 MGaetan89 self-requested a review June 20, 2025 06:13
MGaetan89
MGaetan89 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I just pushed a small change: 0eb0512

@StaehliJ StaehliJ added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit a729363 Jun 20, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the 1049-playbackmetrics-is-available-through-pillarboxplayer-interface branch June 20, 2025 13:10
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PlaybackMetrics is available through PillarboxPlayer interface

2 participants

@StaehliJ @MGaetan89