Conversation
Code Coverage
Files
|
Allowing usage of SmoothProgressTracker even with MediaController.
The showcase add CastPlayer to teste with player that doesn't support it.
StaehliJ
force-pushed
the
1050-investigate-smoothprogresstrackerstate-usable-with-a-pillarboxmediacontroller
branch
from
762fd77 to
89238e2
Compare
MGaetan89
reviewed
Jun 27, 2025
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxPlayer.kt
Outdated
Show resolved
Hide resolved
...-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/layouts/thumbnail/ThumbnailView.kt
Show resolved
Hide resolved
...-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/showcases/layouts/thumbnail/ThumbnailView.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/MediaSessionCallbackImpl.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/MediaSessionCallbackImpl.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxMediaController.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxMediaSession.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxSessionCommands.kt
Outdated
Show resolved
Hide resolved
…ion/MediaSessionCallbackImpl.kt Co-authored-by: Gaëtan Muller <[email protected]>
![github-advanced-security[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/session/MediaSessionCallbackImpl.kt
Fixed
Show fixed
Hide fixed
…ion/PillarboxSessionCommands.kt Co-authored-by: Gaëtan Muller <[email protected]>
…usable-with-a-pillarboxmediacontroller
MGaetan89
reviewed
Jul 3, 2025
Contributor
MGaetan89
left a comment
MGaetan89
left a comment
There was a problem hiding this comment.
There are some unresolved/unanswered comments:
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PillarboxPlayer.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Gaëtan Muller <[email protected]>
…arboxPlayer.kt Co-authored-by: Gaëtan Muller <[email protected]>
…usable-with-a-pillarboxmediacontroller
MGaetan89
approved these changes
Jul 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MGaetan89
deleted the
1050-investigate-smoothprogresstrackerstate-usable-with-a-pillarboxmediacontroller
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR adds some feature that was previously only supported when using
PillarboxExoPlayer.Changes made
PillarboxPlayer.PillarboxPlayer.setImageOutputChecklist