Skip to content

Bump org.jetbrains.kotlinx:kotlinx-datetime from 0.6.2 to 0.7.1#1084

Merged
MGaetan89 merged 7 commits intomainfrom
dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat
Jul 23, 2025
Merged

Bump org.jetbrains.kotlinx:kotlinx-datetime from 0.6.2 to 0.7.1#1084
MGaetan89 merged 7 commits intomainfrom
dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 30, 2025 •
edited by MGaetan89
Loading

Bumps org.jetbrains.kotlinx:kotlinx-datetime from 0.6.2 to 0.7.1.

Release notes

Sourced from org.jetbrains.kotlinx:kotlinx-datetime's releases.

v0.7.0

Breaking changes:

  • Remove kotlinx.datetime.Instant and kotlinx.datetime.Clock in favor of kotlin.time.Instant (#506). See https://github.com/Kotlin/kotlinx-datetime?tab=readme-ov-file#deprecation-of-instant for a description of what to do if this causes problems.
  • Unify the range of admissible LocalDate and LocalDateTime values on all platforms (#432).
  • Rename dayOfMonth to day, monthNumber to month (#84).
  • Make DayOfWeek and Month no longer type aliases to java.time.DayOfWeek and java.time.Month (#96).
  • Make "UTC" and not "Z" be the timezone identifier for TimeZone.UTC (#474).
  • Accept "z" in TimeZone.of, with the same meaning as "Z" (#529).
  • Add DateTimeFormat-based KSerializer implementations for datetime entities, and change the default serializers to be based on toString/parse pairs (#415).

Additions:

  • Add java.io.Serializable implementations for most of the entities in the library (#143). Thanks for spotting and fixing a potential vulnerability, @​lukellmann!
  • Add LocalDateRange, a range of LocalDate values (#190). Thanks, @​PeterAttardo!
  • Add YearMonth and YearMonthRange (#457).

Tweaks and fixes:

  • Support obtaining the system timezone on old Debian-based distributions (#430).
  • Fix not being able to parse some valid timezone identifiers using the timeZoneId() directive (#444).
  • Use the grammar defined in RFC 9557 for parsing timezone identifiers in the timeZoneId() directive, allowing parsing values not present in the timezone database (#531).
  • Improved error messages when formatting an invalid DateTimeComponents value (#471).
  • Set the JPMS dependency on kotlinx.serialization.core to be optional (#496).
Changelog

Sourced from org.jetbrains.kotlinx:kotlinx-datetime's changelog.

CHANGELOG

0.7.0

Breaking changes:

  • Remove kotlinx.datetime.Instant and kotlinx.datetime.Clock in favor of kotlin.time.Instant (#506). See https://github.com/Kotlin/kotlinx-datetime?tab=readme-ov-file#deprecation-of-instant for a description of what to do if this causes problems.
  • Unify the range of admissible LocalDate and LocalDateTime values on all platforms (#432).
  • Rename dayOfMonth to day, monthNumber to month (#84).
  • Make DayOfWeek and Month no longer type aliases to java.time.DayOfWeek and java.time.Month (#96).
  • Make "UTC" and not "Z" be the timezone identifier for TimeZone.UTC (#474).
  • Accept "z" in TimeZone.of, with the same meaning as "Z" (#529).
  • Add DateTimeFormat-based KSerializer implementations for datetime entities, and change the default serializers to be based on toString/parse pairs (#415).

Additions:

  • Add java.io.Serializable implementations for most of the entities in the library (#143). Thanks for spotting and fixing a potential vulnerability, @​lukellmann!
  • Add LocalDateRange, a range of LocalDate values (#190). Thanks, @​PeterAttardo!
  • Add YearMonth and YearMonthRange (#457).

Tweaks and fixes:

  • Support obtaining the system timezone on old Debian-based distributions (#430).
  • Fix not being able to parse some valid timezone identifiers using the timeZoneId() directive (#444).
  • Use the grammar defined in RFC 9557 for parsing timezone identifiers in the timeZoneId() directive, allowing parsing values not present in the timezone database (#531).
  • Improved error messages when formatting an invalid DateTimeComponents value (#471).
  • Set the JPMS dependency on kotlinx.serialization.core to be optional (#496).
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 30, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jun 30, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Jun 30, 2025
@github-actions
Copy link

github-actions bot commented Jun 30, 2025 •
edited
Loading

Code Coverage

Overall Project 48.77% -0.03% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-core-business 78.25% 🟢
Kover Gradle Plugin XML report for :plugins 6.38% -0.66% 🟢
Files
Module File Coverage
:pillarbox-core-business BlockReasonException.kt 100% 🟢
Chapter.kt 58.31% 🟢
Kover Gradle Plugin XML report for :plugins PillarboxAndroidApplicationPlugin.kt 0% -2.86% 🟢
PillarboxAndroidLibraryPlugin.kt 0% 🟢
ProjectExtensions.kt 0% -2.76% 🟢

@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 1, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch from 61bdec0 to 5414ca5 Compare July 1, 2025 06:48
@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 1, 2025

This update deprecates kotlinx.datetime.Instant and kotlinx.datetime.Clock in favor of kotlin.time.Instant and kotlin.time.Clock.
The new classes don't provide a serializer (from kotlinx-serialization). So we need to merge #1085 first (since kotlinx-serialization 1.9.0 does), before being able to merge this PR.

@MGaetan89 MGaetan89 changed the title Bump org.jetbrains.kotlinx:kotlinx-datetime from 0.6.2 to 0.7.0-0.6.x-compat Bump org.jetbrains.kotlinx:kotlinx-datetime from 0.6.2 to 0.7.0 Jul 1, 2025
@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 1, 2025

I've pushed some changes to support this update. But we'll need to merge #1085 first to properly test this.

@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch from 9245adf to 106ad07 Compare July 1, 2025 16:45
StaehliJ
StaehliJ requested changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@StaehliJ StaehliJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chapters can't display correctly, the title is displayed and chapters detection seems to work fine but demo is unable to display chapter image.

Every image can't be displayed, seems to have a side effect with compose coil. Need to wait for latest version of coil to be released https://github.com/coil-kt/coil/blob/main/CHANGELOG.md#330---unreleased

@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 2, 2025

I've updated to Coil 3.3.0-SNAPSHOT in 33aee72.
The images are now working as expected. I've tested the chapters and thumbnail showcases on mobile, and the TV demo app.

I'll revert that commit once Coil 3.3.0 is released. For now I'm putting this in draft, to avoid accidental merge.

@MGaetan89 MGaetan89 marked this pull request as draft July 2, 2025 08:42
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 8, 2025

A newer version of org.jetbrains.kotlinx:kotlinx-datetime exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch from 33aee72 to b38010d Compare July 8, 2025 08:44
@MGaetan89 MGaetan89 changed the title Bump org.jetbrains.kotlinx:kotlinx-datetime from 0.6.2 to 0.7.0 Bump org.jetbrains.kotlinx:kotlinx-datetime from 0.6.2 to 0.7.1 Jul 8, 2025
@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 8, 2025

A newer version of org.jetbrains.kotlinx:kotlinx-datetime exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Thanks @dependabot! I've updated the PR to KotlinX DateTime 0.7.1

@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch from b38010d to 5702e94 Compare July 9, 2025 08:39
@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch from 5702e94 to f16e507 Compare July 22, 2025 09:39
@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 22, 2025

Coil 3.3.0 has been released: https://github.com/coil-kt/coil/blob/main/CHANGELOG.md#330---july-22-2025

I've updated the PR to use it. This should be good for a second review.

@MGaetan89 MGaetan89 marked this pull request as ready for review July 22, 2025 09:54
@MGaetan89 MGaetan89 requested a review from StaehliJ July 22, 2025 09:54
@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch from f16e507 to ea3fbd9 Compare July 23, 2025 07:33
dependabot bot and others added 3 commits July 23, 2025 10:18
@dependabot @MGaetan89
Bump org.jetbrains.kotlinx:kotlinx-datetime
20e2e4f 
Bumps [org.jetbrains.kotlinx:kotlinx-datetime](https://github.com/Kotlin/kotlinx-datetime) from 0.6.2 to 0.7.0-0.6.x-compat.
- [Release notes](https://github.com/Kotlin/kotlinx-datetime/releases)
- [Changelog](https://github.com/Kotlin/kotlinx-datetime/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Kotlin/kotlinx-datetime/commits)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlinx:kotlinx-datetime
  dependency-version: 0.7.0-0.6.x-compat
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@MGaetan89
Update usages of KotlinX DateTime
4f6c0a4
@MGaetan89
Only enable Core Library Desugaring in demo apps
3ae6a01
@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch from ea3fbd9 to 9b33c97 Compare July 23, 2025 08:18
@MGaetan89 MGaetan89 mentioned this pull request Jul 23, 2025
Merged
4 tasks
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit b9ad543 Jul 23, 2025
12 checks passed
@MGaetan89 MGaetan89 deleted the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-datetime-0.7.0-0.6.x-compat branch July 23, 2025 09:45
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MGaetan89 @StaehliJ