Conversation
Code Coverage
Files
|
Contributor
|
When the metrics overlay is enabled, the artwork is displayed on top of the metrics: |
MGaetan89
reviewed
Jul 10, 2025
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/compose/PlayerView.kt
Outdated
Show resolved
Hide resolved
MGaetan89
approved these changes
Jul 16, 2025
...hared/src/main/java/ch/srgssr/pillarbox/demo/shared/ui/player/ShouldDisplayArtworkAsState.kt
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR adds the artwork image of a media item when video track has been disabled or there is no video track. Video track and image track is treated the same.
Changes made
PlayerViewin the mobile and tv demoChecklist