Skip to content

Fix Android Lint check on GitHub Actions#1118

Merged
MGaetan89 merged 1 commit intoupdate-couleur3-mp3-urlfrom
fix_android-lint_ci
Jul 23, 2025
Merged

Fix Android Lint check on GitHub Actions#1118
MGaetan89 merged 1 commit intoupdate-couleur3-mp3-urlfrom
fix_android-lint_ci

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

The github/codeql-action/upload-sarif GitHub Actions no longer supports uploading multiple SHARIF files for a single category.
As we were using this for the Android Lint check, this PR reworks it to use different categories for each module where we run Android Lint.
See this for more information.

Changes made

  • Self-explanatory.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Jul 22, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jul 22, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Jul 22, 2025
@github-actions
Copy link

Code Coverage

Overall Project 48.76% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 marked this pull request as ready for review July 22, 2025 15:33
@MGaetan89 MGaetan89 requested a review from StaehliJ July 22, 2025 15:33
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Jul 22, 2025
@MGaetan89
Copy link
Contributor Author

Note: I'll update the required checks before merging this, once the PR is approved.

@MGaetan89 MGaetan89 mentioned this pull request Jul 22, 2025
4 tasks
@MGaetan89 MGaetan89 changed the base branch from main to update-couleur3-mp3-url July 23, 2025 07:20
@MGaetan89
Copy link
Contributor Author

I'm merging this into #1113, since we need both of them to make the CI pass again.

@MGaetan89 MGaetan89 merged commit 595a657 into update-couleur3-mp3-url Jul 23, 2025
11 of 12 checks passed
@MGaetan89 MGaetan89 deleted the fix_android-lint_ci branch July 23, 2025 07:21
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Jul 23, 2025
github-merge-queue bot pushed a commit to SRGSSR/srgdataprovider-android that referenced this pull request Aug 25, 2025
This PR fixes the `Android Lint` step of the `code_quality.yml`
workflow.
It is no longer possible to upload multiple SARIF files for a single
category. So now we use one category per Gradle module.
This change is based on what was done in
[pillarbox-android](SRGSSR/pillarbox-android#1118).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants