Skip to content

Reset TimeRange tracking when item changes#1121

Merged
MGaetan89 merged 2 commits intomainfrom
fix-same-items-metadata-tracking
Jul 24, 2025
Merged

Reset TimeRange tracking when item changes#1121
MGaetan89 merged 2 commits intomainfrom
fix-same-items-metadata-tracking

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jul 23, 2025

Pull request

Description

Fixes TimeRanges tracking when two same items having the same MediaMetadata are next to each other.

Changes made

  • Reset time range tracking on item transition to ensure the next item is correctly tracked.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jul 23, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 July 23, 2025 12:46
@StaehliJ StaehliJ moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Jul 23, 2025
@github-actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

Code Coverage

Overall Project 48.79% -0.07% 🟢
Files changed 71.79% 🟢

Module Coverage
:pillarbox-player 54.19% -0.13% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxMediaMetaDataTracker.kt 79.42% -4.92% 🟢

@StaehliJ StaehliJ changed the title Reset track when on item changes Reset TimeRange tracking when item changes Jul 24, 2025
@MGaetan89 MGaetan89 enabled auto-merge July 24, 2025 07:45
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit dd2871e Jul 24, 2025
12 checks passed
@MGaetan89 MGaetan89 deleted the fix-same-items-metadata-tracking branch July 24, 2025 07:51
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StaehliJ StaehliJ

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StaehliJ @MGaetan89