Skip to content

Use Media3's states in PlayerPlaybackRow#1123

Merged
MGaetan89 merged 1 commit intomainfrom
1112-improve-player-demo_playback-row
Aug 11, 2025
Merged

Use Media3's states in PlayerPlaybackRow#1123
MGaetan89 merged 1 commit intomainfrom
1112-improve-player-demo_playback-row

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jul 28, 2025 •
edited
Loading

Pull request

Description

This PR updates the PlayerPlaybackRow component in both the pillarbox-demo and pillarbox-demo-tv applications.

Changes made

  • Use Media3's state to read and change the player state.
  • Add missing content descriptions on the playback row icons.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jul 28, 2025
@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Code Coverage

Overall Project 49.16% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 self-assigned this Jul 28, 2025
@MGaetan89 MGaetan89 force-pushed the 1112-improve-player-demo_playback-row branch from f4c8225 to ae1ca44 Compare July 29, 2025 06:14
@MGaetan89 MGaetan89 force-pushed the media3_1.8.0 branch 2 times, most recently from 18bec23 to 17d2dad Compare August 5, 2025 08:14
@MGaetan89 MGaetan89 force-pushed the 1112-improve-player-demo_playback-row branch from ae1ca44 to 5ef4bbb Compare August 7, 2025 07:33
Base automatically changed from media3_1.8.0 to main August 11, 2025 08:19
@MGaetan89 MGaetan89 force-pushed the 1112-improve-player-demo_playback-row branch from 5ef4bbb to a04d2ec Compare August 11, 2025 08:45
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Aug 11, 2025
@MGaetan89 MGaetan89 marked this pull request as ready for review August 11, 2025 08:51
@MGaetan89 MGaetan89 requested review from StaehliJ August 11, 2025 08:53
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Aug 11, 2025
@MGaetan89 MGaetan89 force-pushed the 1112-improve-player-demo_playback-row branch from a04d2ec to 9fa7a2b Compare August 11, 2025 09:45
@MGaetan89 MGaetan89 added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit be4bd1d Aug 11, 2025
12 checks passed
@MGaetan89 MGaetan89 deleted the 1112-improve-player-demo_playback-row branch August 11, 2025 11:27
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Aug 11, 2025
@MGaetan89 MGaetan89 linked an issue Aug 11, 2025 that may be closed by this pull request
Improve Player demo #1112
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ Awaiting requested review from StaehliJ

Assignees

@MGaetan89 MGaetan89

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Player demo

2 participants

@MGaetan89 @StaehliJ