Skip to content

Add a state to manage Picture-in-Picture#1126

Merged
MGaetan89 merged 2 commits intomainfrom
1112-improve-player-demo_picture-in-picture
Jul 30, 2025
Merged

Add a state to manage Picture-in-Picture#1126
MGaetan89 merged 2 commits intomainfrom
1112-improve-player-demo_picture-in-picture

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

This PR introduces a state object to handle the Picture-in-Picture state and interactions, following the approach used in Media3's ui-compose module.

Changes made

  • Introduce a PictureInPictureButtonState.
  • Update demo players that support Picture-in-Picture to use PictureInPictureButtonState.
  • Update DemoPlayer to always display the Picture-in-Picture button. But it can be disabled if Picture-in-Picture is not supported. This follows what Media3 is doing in its Compose demo.
  • Update the Readme to reflect the recent min SDK change.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Jul 29, 2025
@MGaetan89 MGaetan89 linked an issue Jul 29, 2025 that may be closed by this pull request
1 task
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jul 29, 2025
@github-actions
Copy link

github-actions bot commented Jul 29, 2025

Code Coverage

Overall Project 48.82% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 marked this pull request as ready for review July 29, 2025 09:48
@MGaetan89 MGaetan89 requested a review from StaehliJ July 29, 2025 09:48
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Jul 29, 2025
@MGaetan89 MGaetan89 removed a link to an issue Jul 29, 2025
1 task
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit 032a30e Jul 30, 2025
12 checks passed
@MGaetan89 MGaetan89 deleted the 1112-improve-player-demo_picture-in-picture branch July 30, 2025 13:11
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Jul 30, 2025
@MGaetan89 MGaetan89 linked an issue Jul 30, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Improve Player demo

2 participants