Add a state to manage Picture-in-Picture#1126
Merged
Conversation
Closed
1 task
Code Coverage
|
StaehliJ
reviewed
Jul 30, 2025
...x-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/state/PictureInPictureButtonState.kt
Outdated
Show resolved
Hide resolved
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/controls/PlayerBottomToolbar.kt
Show resolved
Hide resolved
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/controls/PlayerBottomToolbar.kt
Show resolved
Hide resolved
StaehliJ
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR introduces a state object to handle the Picture-in-Picture state and interactions, following the approach used in Media3's
ui-composemodule.Changes made
PictureInPictureButtonState.PictureInPictureButtonState.DemoPlayerto always display the Picture-in-Picture button. But it can be disabled if Picture-in-Picture is not supported. This follows what Media3 is doing in its Compose demo.Checklist