Use Media3 states for shuffle and repeat in :pillarbox-demo#1133
Merged
Use Media3 states for shuffle and repeat in :pillarbox-demo#1133
:pillarbox-demo#1133Conversation
MGaetan89
changed the title
:pillarbox-demo
![github-advanced-security[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Code Coverage
Files
|
MGaetan89
commented
Aug 7, 2025
pillarbox-ui/src/main/java/ch/srgssr/pillarbox/ui/extension/ComposablePlayer.kt
Outdated
Show resolved
Hide resolved
4 tasks
StaehliJ
approved these changes
Aug 11, 2025
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/controls/PlayerBottomToolbar.kt
Show resolved
Hide resolved
MGaetan89
force-pushed
the
1112-improve-player-demo_shuffle-repeat
branch
from
a5309db to
adb0f58
Compare
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR integrates Media3's
RepeatButtonStateandShuffleButtonStateto manage the corresponding buttons in:pillarbox-demo.Changes made
RepeatButtonStateandShuffleButtonStateto manage the repeat and shuffle buttons in:pillarbox-demo.PlayerBottomToolbarinto smaller components for readability.Player.shuffleModeEnabledAsState()andPlayer.repeatModeAsState()in favor of the Media3 solution.Checklist