Skip to content

Use Media3 states for shuffle and repeat in :pillarbox-demo-tv#1134

Merged
MGaetan89 merged 1 commit into928-custom-castplayerfrom
1112-improve-player-demo_shuffle-repeat-tv
Aug 11, 2025
Merged

Use Media3 states for shuffle and repeat in :pillarbox-demo-tv#1134
MGaetan89 merged 1 commit into928-custom-castplayerfrom
1112-improve-player-demo_shuffle-repeat-tv

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

This PR integrates Media3's RepeatButtonState and ShuffleButtonState to manage the corresponding buttons in :pillarbox-demo-tv.

This PR is similar to #1133 but focuses on the TV demo.

Changes made

  • Use RepeatButtonState and ShuffleButtonState to manage the repeat and shuffle buttons in :pillarbox-demo-tv.
  • Create a PlayerToolbar component out of PlayerView for readability.
  • Extract the SkipButton into its own file.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Aug 7, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Aug 7, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Aug 7, 2025
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Code Coverage

Overall Project 45.79% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 marked this pull request as ready for review August 7, 2025 15:34
@MGaetan89 MGaetan89 requested a review from StaehliJ August 7, 2025 15:34
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Aug 7, 2025
@MGaetan89 MGaetan89 merged commit 12f8e07 into 928-custom-castplayer Aug 11, 2025
12 checks passed
@MGaetan89 MGaetan89 deleted the 1112-improve-player-demo_shuffle-repeat-tv branch August 11, 2025 08:29
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Aug 11, 2025
@MGaetan89 MGaetan89 linked an issue Aug 11, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Improve Player demo

2 participants