Fix missing event when reaching the end of a credit#1136
Merged
Conversation
MGaetan89
force-pushed
the
fix-end-credit-event
branch
from
9a25ae0 to
b0a7bcf
Compare
![github-advanced-security[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pillarbox-player/src/test/java/ch/srgssr/pillarbox/player/PillarboxExoPlayerTest.kt
Fixed
Show fixed
Hide fixed
MGaetan89
force-pushed
the
fix-end-credit-event
branch
6 times, most recently
from
101a06f to
f56a16c
Compare
MGaetan89
force-pushed
the
fix-end-credit-event
branch
from
f56a16c to
6875bc8
Compare
Code Coverage
Files
|
StaehliJ
requested changes
Aug 13, 2025
pillarbox-player/src/test/java/ch/srgssr/pillarbox/player/PillarboxExoPlayerTest.kt
Show resolved
Hide resolved
MGaetan89
force-pushed
the
fix-end-credit-event
branch
from
338e9df to
c796d25
Compare
MGaetan89
force-pushed
the
fix-end-credit-event
branch
from
c796d25 to
4bd59eb
Compare
StaehliJ
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Currently, when reaching the end of a credit, we call
PillarboxExoPlayer.notifyTimeRangeChanged(null), wherenotifyTimeRangeChanged()takes aTimeRange.However, when passing
null, we don't know what kind of time range we should handle. This means that we never callPillarboxPlayer.Listener.onCreditChanged().This PR fixes that by splitting
notifyTimeRangeChanged()in three distinct methods:notifyBlockedTimeRangeChanged(),notifyChapterChange(), andnotifyCreditChange().Changes made
Checklist