1122 add role and subtype of mediatrack#1139
Merged
MGaetan89 merged 13 commits into928-custom-castplayerfrom Aug 29, 2025
Merged
1122 add role and subtype of mediatrack#1139MGaetan89 merged 13 commits into928-custom-castplayerfrom
MGaetan89 merged 13 commits into928-custom-castplayerfrom
Conversation
Code Coverage
Files
|
MGaetan89
reviewed
Aug 26, 2025
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/Track.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/Track.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/Track.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/Track.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/Track.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/MediaTrack.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/MediaTrack.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/MediaTrack.kt
Outdated
Show resolved
Hide resolved
MGaetan89
approved these changes
Aug 28, 2025
Contributor
MGaetan89
left a comment
MGaetan89
left a comment
There was a problem hiding this comment.
Just some minor comments. Otherwise it looks good 👍🏻
...st-receiver/src/main/java/ch/srgssr/pillarbox/cast/receiver/PillarboxMediaCommandCallback.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/test/java/ch/srgssr/pillarbox/cast/DefaultFormatAdapterToSelectionFlags.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/test/java/ch/srgssr/pillarbox/cast/DefaultFormatAdapterToSelectionFlags.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/TracksConverter.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/TracksConverter.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/TracksConverter.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/DefaultTracksConverter.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/DefaultTracksConverter.kt
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/DefaultTracksConverter.kt
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/DefaultTracksConverter.kt
Outdated
Show resolved
Hide resolved
…ormatAdapterToSelectionFlags.kt Co-authored-by: Gaëtan Muller <[email protected]>
MGaetan89
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to enhance media tracks information between Remote and Local playback.
Changes made
Checklist