Skip to content

Use currentTime from loadRequest instead of startTime from queueData#1189

Merged
StaehliJ merged 1 commit intomainfrom
fix-start-time
Oct 13, 2025
Merged

Use currentTime from loadRequest instead of startTime from queueData#1189
StaehliJ merged 1 commit intomainfrom
fix-start-time

Conversation

@waliid
Copy link
Member

@waliid waliid commented Oct 8, 2025

Description

This PR fixes an issue with the Android Cast Receiver that was unable to start playback at the correct position.

Changes made

  • The loadRequest.currentTime has been used instead of queueData.startTime.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Oct 8, 2025
@waliid waliid changed the title Use currentTime from loadRequest instead of startTime from queueData. Use currentTime from loadRequest instead of startTime from queueData Oct 8, 2025
@waliid waliid added the bug Something isn't working label Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Code Coverage

Overall Project 47.72% -0.03% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-cast-receiver 20.41% -0.5% 🟢
Files
Module File Coverage
:pillarbox-cast-receiver PillarboxCastReceiverPlayer.kt 0% -1.49% 🟢

@waliid waliid moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Oct 10, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit 2fda26e Oct 13, 2025
20 of 21 checks passed
@StaehliJ StaehliJ deleted the fix-start-time branch October 13, 2025 08:45
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants