Skip to content

1008 replace smooth seeking with scrubbingmode#1212

Merged
StaehliJ merged 6 commits intomainfrom
1008-replace-smoothSeeking-with-scrubbingmode
Dec 8, 2025
Merged

1008 replace smooth seeking with scrubbingmode#1212
StaehliJ merged 6 commits intomainfrom
1008-replace-smoothSeeking-with-scrubbingmode

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Nov 18, 2025

Description

Media3 introduce scrubbingMode to ExoPlayer that does exactly what Pillarbox smooth seeking is doing. The goal of this PR is to replace it with the media3 way.

Changes made

  • Change SimpleProgressTracker that handle also scrubbingMode
  • Old SmoothingSeekingProgressTrackerState is now dedicated to thumbnail seeking from player image track.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Nov 18, 2025 that may be closed by this pull request
Investigate setScrubbingModeEnabled to remove setSmoothSeeking #1008
Closed
5 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025 •
edited
Loading

Code Coverage

Overall Project 48.12% -0.67% 🟢
Files changed 12.29% 🟢

Module Coverage
:pillarbox-player 57.49% -0.56% 🟢
:pillarbox-cast 29.19% -0.05% 🟢
:pillarbox-cast-receiver 20.01% 🟢
:pillarbox-ui 3.62% -3.06% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxExoPlayer.kt 88.57% 🟢
PillarboxAnalyticsCollector.kt 87.13% 🟢
PillarboxBuilder.kt 79.17% 🟢
PillarboxLoadControl.kt 78.26% 🟢
PillarboxPlayer.kt 5.36% 🟢
PillarboxAnalyticsListener.kt 0% 🟢
PillarboxSessionCommands.kt 0% -9.32% 🟢
PillarboxMediaController.kt 0% -1.83% 🟢
PillarboxMediaSession.kt 0% 🟢
MediaSessionCallbackImpl.kt 0% -9.81% 🟢
:pillarbox-cast PillarboxCastPlayer.kt 1.07% -0.1% 🟢
:pillarbox-cast-receiver PillarboxCastReceiverPlayer.kt 0% 🟢
:pillarbox-ui ImageProgressTrackerState.kt 0% -57.34% 🟢
SimpleProgressTrackerState.kt 0% -57.35% 🟢

@JordanMontel JordanMontel removed the status in Pillarbox Nov 24, 2025
@StaehliJ StaehliJ requested review from defagos and waliid November 28, 2025 10:51
@StaehliJ StaehliJ moved this to 🍿 Code Review in Pillarbox Nov 28, 2025
waliid
waliid reviewed Dec 1, 2025
View reviewed changes
@StaehliJ StaehliJ enabled auto-merge December 2, 2025 10:16
@StaehliJ StaehliJ requested a review from waliid December 2, 2025 13:35
@StaehliJ StaehliJ added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Dec 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025
@StaehliJ StaehliJ enabled auto-merge December 8, 2025 11:38
@StaehliJ StaehliJ added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit d280413 Dec 8, 2025
12 checks passed
@StaehliJ StaehliJ deleted the 1008-replace-smoothSeeking-with-scrubbingmode branch December 8, 2025 11:46
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waliid waliid waliid approved these changes

@defagos defagos Awaiting requested review from defagos

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate setScrubbingModeEnabled to remove setSmoothSeeking

3 participants

@StaehliJ @waliid @JordanMontel