Skip to content

Share eagerly current player#1227

Merged
StaehliJ merged 3 commits intomainfrom
1223-fix-cast-available-flow
Jan 7, 2026
Merged

Share eagerly current player#1227
StaehliJ merged 3 commits intomainfrom
1223-fix-cast-available-flow

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Dec 9, 2025

Description

The goal of this PR is to fix CastPlayer.isCastSessionAvailableAsFlow when used with collectAsStateWithLifecycle and the application goes in background without going connecting to a remote session.

Changes made

  • currentPlayer using SharingStarted.Eagerly.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Code Coverage

Overall Project 48.09% -0.04% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-cast 29.21% -0.37% 🟢
Files
Module File Coverage
:pillarbox-cast CastPlayerSynchronizer.kt 0% -5.76% 🟢

@StaehliJ StaehliJ moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Jan 6, 2026
@defagos defagos linked an issue Jan 6, 2026 that may be closed by this pull request
@StaehliJ StaehliJ added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit f916d6c Jan 7, 2026
13 checks passed
@StaehliJ StaehliJ deleted the 1223-fix-cast-available-flow branch January 7, 2026 09:40
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Fix isCastSessionAvailableAsFlow

2 participants