Skip to content

Fix monitoring allway sending no assetUrl#1241

Merged
StaehliJ merged 1 commit intomainfrom
fix-monitoring-asset-url
Jan 27, 2026
Merged

Fix monitoring allway sending no assetUrl#1241
StaehliJ merged 1 commit intomainfrom
fix-monitoring-asset-url

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jan 27, 2026

Description

Fix monitoring not sending asset url on session start.

Changes made

  • Self-explanatory

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Jan 27, 2026 that may be closed by this pull request
asset_url is not populated in the monitoring #1238
Closed
2 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jan 27, 2026
@StaehliJ StaehliJ requested a review from jboix January 27, 2026 08:17
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Code Coverage

Overall Project 44.72% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 57.72% 🟢
Files
Module File Coverage
:pillarbox-player Monitoring.kt 92.77% 🟢

jboix
jboix approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@jboix jboix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StaehliJ StaehliJ added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2026
@StaehliJ StaehliJ added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit 69b7b7e Jan 27, 2026
12 checks passed
@StaehliJ StaehliJ deleted the fix-monitoring-asset-url branch January 27, 2026 09:15
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jboix jboix jboix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

asset_url is not populated in the monitoring

2 participants

@StaehliJ @jboix