Fix aspect ratio when pixelWidthHeightRatio not equal 1#1244
Merged
Conversation
…s always set to 1. For vertical video using this.pixelWidthHeightRatio to flip the video it won't work.
Code Coverage
Files
|
defagos
approved these changes
Feb 11, 2026
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/VideoSize.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue when content playing needs
VideoSize.pixelWidthHeightRatioto make the video vertical instead of horizontal. This PR remove the computing of the aspect ratio from video tracks becauseFomat.pixelWidthHeighRatioalways return 1 instead of the correct value.The issue affect only the depreciated
PlayerSurfaceand anyone usingPlayer.getAspectRatioAsFlowandPlayer.getAspectRatioAsState.Changes made
VideoSize.Checklist