Conversation
Closed
1 task
![github-advanced-security[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <string name="examples">Examples</string> | ||
| <string name="lists">Lists</string> | ||
| <string name="search">Search</string> | ||
| <string name="change_bu">Change BU</string> |
Check warning
Code scanning / Android Lint
Unused resources
| <string name="examples">Examples</string> | ||
| <string name="lists">Lists</string> | ||
| <string name="search">Search</string> | ||
| <string name="change_bu">Change BU</string> |
Check warning
Code scanning / Android Lint
Unused resources
Code Coverage
|
StaehliJ
reviewed
Dec 10, 2024
Contributor
StaehliJ
left a comment
StaehliJ
left a comment
There was a problem hiding this comment.
Some little adjustement maybe, Shouldn't we not focus automatically the top when user choose an item in the bottom navigation bar ?
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/settings/AppSettingsView.kt
Show resolved
Hide resolved
Contributor
Author
I've checked in multiple Google apps, and the behavior is always the same: when we select a tab in the bottom navigation, the focus remains there. |
MGaetan89
force-pushed
the
803-accessibility
branch
from
2dac488 to
c51a6ab
Compare
StaehliJ
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Improve accessibility in the demo app itself. These are mostly navigation-related changes. The player will be handled separately.
Changes made
DemoItems so TalkBack can use the proper voice when reading information.Checklist