Improve accessibility in "Showcases" and on the player#821

Merged

MGaetan89 merged 6 commits intomainfrom

803-accessibility_2

Dec 12, 2024

Contributor

MGaetan89 commented Dec 6, 2024 •

edited

Loading

Pull request

Description

This improves accessibility in the "Showcases" section and on the player.

Changes made

Adjust PillarboxSlider when TalkBack is enabled, i.e.:
- Enforce non-compact mode.
- Add vertical padding.
- Add progress information.
Migrate player settings to Material 3 Bottom Sheet (instead of Material Navigation Bottom Sheet). The former provides better accessibility support.
Remove Gradle cache support in the build_windows.yml workflow. This action differentiates cache by platform, so this was unnecessary since we never store cache for Windows builds.

Checklist

APIs have been properly documented (if relevant).
The documentation has been updated (if relevant).
New unit tests have been written (if relevant).
The demo has been updated (if relevant).

MGaetan89 linked an issue

that may be closed by this pull request

Accessibility #803

Closed

1 task

MGaetan89 self-assigned this

github-actions bot commented Dec 6, 2024 •

edited

Loading

Code Coverage

Overall Project	48.65%	🟢

There is no coverage information present for the Files changed

MGaetan89 requested a review from StaehliJ

December 9, 2024 08:44

StaehliJ reviewed

View reviewed changes

Contributor

StaehliJ left a comment

We should remove Overlay text from TalkBack.
TalkBack in French say "2 metres 12" instead of a time.
The toggle controls text should be more explicite. But it is better than before.
When double drag in TalkBack, the controls are hide but nothing tells user in has been hidden and nothing tells what to do next.

Contributor Author

MGaetan89 commented Dec 10, 2024 •

edited

Loading

Check if we should lower media volume when TalkBack speaks
Replace the emoji name with the media type
Replace URN with comment in DemoItem description
Increase slider height

MGaetan89 added 3 commits

December 10, 2024 10:05


          Improve accessibility in the demo app

ab44891


          Fix build of the TV demo

3fbbb5b


          Make TalkBack inform about the selected item

c51a6ab

MGaetan89 force-pushed the 803-accessibility branch from 2dac488 to c51a6ab Compare

December 10, 2024 16:06

MGaetan89 added 3 commits

December 10, 2024 17:07


          Improve accessibility in "Showcases" and on the player

452a9b8


          Remove Gradle cache from the build_windows.yml workflow

a111294


          - Replace media type emoji with labels.

cbb5816

- Don't speak out metrics overlay.
- Increase the height of the slider.
- Speak out the slider progress as a percentage.
- Add state label to the player control view.

MGaetan89 force-pushed the 803-accessibility_2 branch from 130fe0c to cbb5816 Compare

December 10, 2024 19:00

Contributor Author

MGaetan89 commented Dec 10, 2024 •

edited

Loading

We should remove Overlay text from TalkBack.

Done ✅

TalkBack in French say "2 metres 12" instead of a time.

Changed to speak out the progress in percentage instead ✅

The toggle controls text should be more explicite. But it is better than before.

Added an accessibility label to describe the state of the controls ("Controls visible"/"Controls hidden") ✅

When double drag in TalkBack, the controls are hide but nothing tells user in has been hidden and nothing tells what to do next.

~~I'll look into this tomorrow ⏳~~
We're using Compose's toggleable Modifier, so accessibility should already be set up properly ✅

Check if we should lower media volume when TalkBack speaks

I'll look into this tomorrow ⏳

Replace the emoji name with the media type

Done ✅

Replace URN with comment in DemoItem description

Done ✅

Increase slider height

Done ✅

github-advanced-security bot found potential problems

View reviewed changes

pillarbox-demo-shared/src/main/res/values/strings.xml

                   <string name="search_placeholder">Search for content</string>
                   <string name="no_results">No results</string>
                   <string name="empty_search_query">Enter something to search</string>
+                  <string name="audio_content">Audio</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.audio_content appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

                   <string name="search_placeholder">Search for content</string>
                   <string name="no_results">No results</string>
                   <string name="empty_search_query">Enter something to search</string>
+                  <string name="audio_content">Audio</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.audio_content appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

                   <string name="no_results">No results</string>
                   <string name="empty_search_query">Enter something to search</string>
+                  <string name="audio_content">Audio</string>
+                  <string name="video_content">Video</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.video_content appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

                   <string name="no_results">No results</string>
                   <string name="empty_search_query">Enter something to search</string>
+                  <string name="audio_content">Audio</string>
+                  <string name="video_content">Video</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.video_content appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

                   <string name="empty_search_query">Enter something to search</string>
+                  <string name="audio_content">Audio</string>
+                  <string name="video_content">Video</string>
+                  <string name="controls_visible">Controls visible</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.controls_visible appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

                   <string name="empty_search_query">Enter something to search</string>
+                  <string name="audio_content">Audio</string>
+                  <string name="video_content">Video</string>
+                  <string name="controls_visible">Controls visible</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.controls_visible appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

+                  <string name="audio_content">Audio</string>
+                  <string name="video_content">Video</string>
+                  <string name="controls_visible">Controls visible</string>
+                  <string name="controls_hidden">Controls hidden</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.controls_hidden appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

+                  <string name="audio_content">Audio</string>
+                  <string name="video_content">Video</string>
+                  <string name="controls_visible">Controls visible</string>
+                  <string name="controls_hidden">Controls hidden</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.controls_hidden appears to be unused

Contributor Author

MGaetan89 commented Dec 11, 2024

Check if we should lower media volume when TalkBack speaks

I'll look into this tomorrow ⏳

Android provides dedicated volume settings for TalkBack and Media. Maybe we should just let the user/system handle that, instead of trying to manage it ourselves. What do you think?
https://support.google.com/accessibility/android/answer/6283655?hl=en#:~:text=Change%20the%20volume%20for%20TalkBack

StaehliJ approved these changes

View reviewed changes

Base automatically changed from 803-accessibility to main

December 12, 2024 05:49

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

Merged via the queue into main with commit e01699c

MGaetan89 deleted the 803-accessibility_2 branch

December 12, 2024 06:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet