Merged
Conversation
Code Coverage
|
MGaetan89
approved these changes
Dec 19, 2024
Contributor
MGaetan89
left a comment
MGaetan89
left a comment
There was a problem hiding this comment.
Looks good 👍🏻
Just a couple suggestions/questions.
app_name is also defined in src/nightlyDebug/res/values/strings.xml.
Does it make sense to have that definition, since the nightly flavor is only enabled on CI, where we do a release build?
Co-authored-by: Gaëtan Muller <[email protected]>
Co-authored-by: Gaëtan Muller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Add prefix emoji to differentiate builds.
🐛 Pillarbox Demo Debug🌙 Pillarbox Demo NightlyChanges made
Checklist