Skip to content

Add shuffle support to CastPlayer#878

Merged
MGaetan89 merged 10 commits intomainfrom
869-handle-shuffle-mode-with-castplayer
Jan 29, 2025
Merged

Add shuffle support to CastPlayer#878
MGaetan89 merged 10 commits intomainfrom
869-handle-shuffle-mode-with-castplayer

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jan 28, 2025

Pull request

Description

This PR adds support for shuffle mode with a CastPlayer. This fixes #869.

Changes made

  • Update PillarboxCastPlayer to be able to customize the default internal CastPlayer.
  • Make PillarboxCastPlayer override shuffle/repeat mode methods.
  • Add showShuffleButton and showSubtitleButton arguments to ExoPlayerView.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 linked an issue Jan 28, 2025 that may be closed by this pull request
Handle shuffle mode with CastPlayer #869
Closed
@github-actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

Code Coverage

Overall Project 51.46% -0.86% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-ui 0.27% -0.72% 🟢
:pillarbox-cast 0% -61.85% 🟢
Files
Module File Coverage
:pillarbox-ui ExoPlayerView.kt 0% -4.65% 🟢
:pillarbox-cast PillarboxCastPlayer.kt 0% -94.58% 🟢

StaehliJ
StaehliJ approved these changes Jan 28, 2025
View reviewed changes
@StaehliJ StaehliJ added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit d3f55ae Jan 29, 2025
9 checks passed
@MGaetan89 MGaetan89 deleted the 869-handle-shuffle-mode-with-castplayer branch January 29, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle shuffle mode with CastPlayer

2 participants

@MGaetan89 @StaehliJ