Don't force PillarboxExoPlayer instance in Services#890
Merged
Conversation
Code Coverage
Files
|
MGaetan89
reviewed
Feb 13, 2025
...rbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxMediaLibraryService.kt
Outdated
Show resolved
Hide resolved
...rbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxMediaLibraryService.kt
Show resolved
Hide resolved
...rbox-player/src/main/java/ch/srgssr/pillarbox/player/session/PillarboxMediaSessionService.kt
Outdated
Show resolved
Hide resolved
MGaetan89
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to allow any instance of
PillarboxPlayerto be set inPillarboxMediaSessionServiceandPillarboxMediaLiabraryServicelike it is already done for sessions.Changes made
PillarboxMediaSessionService.setPlayertakes aPillarboxPlayerinstead of aPillarboxExoPlayer.PillarboxMediaLiabraryService.setPlayertakes aPillarboxPlayerinstead of aPillarboxExoPlayer.setWakeMode(C.WAKE_MODE_NETWORK). This have to be done by the user.Checklist