929 simple base implementation#943
Conversation
![github-advanced-security[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| set(value) {} | ||
| private val castPlayerListener = InternalCastPlayerListener() | ||
| private val mediaItemConverter: MediaItemConverter, | ||
| @IntRange(from = 1) private val seekBackIncrementMs: Long, |
Check warning
Code scanning / detekt
Property is unused and should be removed. Warning
| private val castPlayerListener = InternalCastPlayerListener() | ||
| private val mediaItemConverter: MediaItemConverter, | ||
| @IntRange(from = 1) private val seekBackIncrementMs: Long, | ||
| @IntRange(from = 1) private val seekForwardIncrementMs: Long, |
Check warning
Code scanning / detekt
Property is unused and should be removed. Warning
| private val mediaItemConverter: MediaItemConverter, | ||
| @IntRange(from = 1) private val seekBackIncrementMs: Long, | ||
| @IntRange(from = 1) private val seekForwardIncrementMs: Long, | ||
| @IntRange(from = 0) private val maxSeekToPreviousPositionMs: Long, |
Check warning
Code scanning / detekt
Property is unused and should be removed. Warning
| private val mediaQueueCallback = MediaQueueCallback() | ||
| private val analyticsCollector = DefaultAnalyticsCollector(clock).apply { addListener(EventLogger()) } | ||
|
|
||
| var sessionAvailabilityListener: SessionAvailabilityListener? = null |
Check warning
Code scanning / detekt
Public properties require documentation. Warning
|
|
||
| var sessionAvailabilityListener: SessionAvailabilityListener? = null | ||
|
|
||
| var remoteMediaClient: RemoteMediaClient? = null |
Check warning
Code scanning / detekt
Public properties require documentation. Warning
| }, | ||
| ) | ||
|
|
||
| MainView(player = player, modifier = Modifier) |
Check warning
Code scanning / Android Lint
Synthetic Accessor Warning
|
We know that not every checks passes, it is a in progress tasks. |
1 participant
Pull request
Description
The first iteration to implement basic player features.
Changes made
PillarboxCastPlayerwith less feature that beforel.Checklist