Skip to content

Add support for shuffle and repeat modes to Cast player#951

Merged
StaehliJ merged 1 commit into928-custom-castplayerfrom
932-handle-shuffle-mode-and-repeat-mode
Mar 20, 2025
Merged

Add support for shuffle and repeat modes to Cast player#951
StaehliJ merged 1 commit into928-custom-castplayerfrom
932-handle-shuffle-mode-and-repeat-mode

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Mar 19, 2025

Pull request

Description

This commit adds support for repeat mode and shuffle mode to PillarboxCastPlayer.

Changes made

  • Update PillarboxCastPlayer state to include the shuffle mode and repeat mode.
  • Implement handleSetShuffleModeEnabled(Boolean) and handleSetRepeatMode(Int) in PillarboxCastPlayer.
  • Add COMMAND_SET_SHUFFLE_MODE and COMMAND_SET_REPEAT_MODE to the list of supported commands in PillarboxCastPlayer.
  • Update pillarbox-demo-cast to support changing the repeat mode.
  • Add some missing dependencies declarations.
  • Fix some warnings.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Mar 19, 2025
@MGaetan89 MGaetan89 linked an issue Mar 19, 2025 that may be closed by this pull request
Handle shuffle mode and repeat mode #932
Closed
@MGaetan89 MGaetan89 marked this pull request as ready for review March 19, 2025 14:40
@MGaetan89 MGaetan89 requested a review from StaehliJ March 19, 2025 14:41
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Mar 19, 2025

The failing tests seem to be related to the current IL issue on RSI side.

@github-actions
Copy link

github-actions bot commented Mar 19, 2025

Code Coverage

Overall Project 50.62% -0.47% 🟢
Files changed 3.82% 🟢

Module Coverage
:pillarbox-cast 8.37% -9.95% 🟢
Files
Module File Coverage
:pillarbox-cast PillarboxCastPlayer.kt 4.08% -15.02% 🟢

@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Mar 19, 2025

The failing tests seem to be related to the current IL issue on RSI side.

It's all good now

@StaehliJ StaehliJ merged commit 9a2962a into 928-custom-castplayer Mar 20, 2025
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Mar 20, 2025
@StaehliJ StaehliJ deleted the 932-handle-shuffle-mode-and-repeat-mode branch March 20, 2025 09:49
@MGaetan89 MGaetan89 mentioned this pull request Mar 20, 2025
Closed
4 tasks
StaehliJ pushed a commit that referenced this pull request Apr 2, 2025
@MGaetan89 @StaehliJ
Add support for shuffle and repeat modes to Cast player (#951)
73c3ac8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ requested changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle shuffle mode and repeat mode

2 participants

@MGaetan89 @StaehliJ