Skip to content

931 handle seek next previous position index#953

Merged
StaehliJ merged 6 commits into928-custom-castplayerfrom
931-handle-seek-next-previous-position-index
Mar 21, 2025
Merged

931 handle seek next previous position index#953
StaehliJ merged 6 commits into928-custom-castplayerfrom
931-handle-seek-next-previous-position-index

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Mar 20, 2025

Pull request

Description

Handle next and previous buttons, some other commands has to been added because exoplayer view. The corresponding handle will be done in an other story #952 .

Changes made

  • Self-Explanatory

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Mar 20, 2025 that may be closed by this pull request
Handle seek (next, previous, position, index) #931
Closed
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Mar 20, 2025
@StaehliJ StaehliJ changed the base branch from main to 928-custom-castplayer March 20, 2025 09:25
@github-actions
Copy link

github-actions bot commented Mar 20, 2025 •
edited
Loading

Code Coverage

Overall Project 50.34% -0.73% 🟢
Files changed 1.25% 🟢

Module Coverage
:pillarbox-cast 7.56% -14.1% 🟢
Files
Module File Coverage
:pillarbox-cast PillarboxCastPlayer.kt 3.51% -20.29% 🟢

@StaehliJ StaehliJ force-pushed the 931-handle-seek-next-previous-position-index branch from cb7ea24 to 9671c3c Compare March 20, 2025 09:52
MGaetan89
MGaetan89 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I've pushed a couple of simple changes:

  • 874789c: make getState() more readable.
  • 13689f2: remove redundant null check.
  • 02c9012: avoid null checks in jumpTo().

@StaehliJ StaehliJ merged commit fb5eb48 into 928-custom-castplayer Mar 21, 2025
9 of 10 checks passed
@StaehliJ StaehliJ deleted the 931-handle-seek-next-previous-position-index branch March 21, 2025 14:28
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Mar 21, 2025
StaehliJ added a commit that referenced this pull request Apr 2, 2025
@StaehliJ @MGaetan89
931 handle seek next previous position index (#953)
6cf27ac 
Co-authored-by: Gaëtan Muller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle seek (next, previous, position, index)

2 participants

@StaehliJ @MGaetan89