Add a method to access the RemoteMediaClient in PillarboxCastPlayer#956
Merged
StaehliJ merged 2 commits into928-custom-castplayerfrom Mar 27, 2025
Merged
Conversation
a0eb242 to
98c341c
Compare
a298993 to
98c341c
Compare
98c341c to
ea91e27
Compare
Code Coverage
Files
|
4 tasks
Call invalideState if needed inside the command
StaehliJ
approved these changes
Mar 27, 2025
StaehliJ
added a commit
that referenced
this pull request
Apr 2, 2025
…r` (#956) Co-authored-by: Joaquim Stähli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR simplifies the usage of
RemoteMediaClientinPillarboxCastPlayerby providing awithRemoteClientmethod that takes care of ensuring that theRemoteMediaClientis notnull, optionally invalidating the state, and returning aFutures.immediateVoidFuture().Example:
Changes made
withRemoteClient()method toPillarboxCastPlayer.PillarboxCastOptionProviderto use constants for the different receiver ids.Checklist