Skip to content

Remove preload for some demo#964

Merged
MGaetan89 merged 2 commits intomainfrom
remove-preload-for-some-demo
Mar 31, 2025
Merged

Remove preload for some demo#964
MGaetan89 merged 2 commits intomainfrom
remove-preload-for-some-demo

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Mar 28, 2025

Pull request

Description

Some show case demo doesn't work anymore since we introduce preload configuration by default in the demo DI. The showcases that doesn't work are:

  • 360° showcase
  • Mutliplayer showcase

Changes made

  • Create PillarboxExoPlayer without preload configuration

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Mar 28, 2025
@StaehliJ StaehliJ added the bug Something isn't working label Mar 28, 2025
@StaehliJ StaehliJ added this to the Demo milestone Mar 28, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 March 28, 2025 15:55
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

Code Coverage

Overall Project 50.84% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Mar 31, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Mar 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Mar 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit b1b2a94 Mar 31, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the remove-preload-for-some-demo branch March 31, 2025 08:13
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StaehliJ StaehliJ

Labels

bug Something isn't working

Projects

Pillarbox
Status: ✅ Done

Milestone

Demo

Development

Successfully merging this pull request may close these issues.

2 participants

@StaehliJ @MGaetan89