Allow getting the device info from PillarboxCastPlayer#965
Merged
StaehliJ merged 1 commit into928-custom-castplayerfrom Apr 2, 2025
Merged
Allow getting the device info from PillarboxCastPlayer#965StaehliJ merged 1 commit into928-custom-castplayerfrom
PillarboxCastPlayer#965StaehliJ merged 1 commit into928-custom-castplayerfrom
Conversation
Closed
Code Coverage
Files
|
MGaetan89
force-pushed
the
937-get-device-info
branch
from
ac9e0e1 to
056228b
Compare
StaehliJ
approved these changes
Apr 2, 2025
StaehliJ
pushed a commit
that referenced
this pull request
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR adds the necessary logic for the
getDeviceInfo()to function as expected. The implementation is based on what is done in Media3 1.6.0.Changes made
deviceInfofield of the PlayerStateobject.Checklist