Skip to content

Handle seek to time#974

Merged
StaehliJ merged 8 commits into928-custom-castplayerfrom
952-handle-seek
Apr 9, 2025
Merged

Handle seek to time#974
StaehliJ merged 8 commits into928-custom-castplayerfrom
952-handle-seek

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Apr 2, 2025 •
edited
Loading

Pull request

Description

The goal of this PR is to add the seek in time feature into PillarboxCastPlayer.

Changes made

  • PillarboxCastPlayer invalidateState is called periodically by ProgressListener.
  • Handles seekTo, seekBack, seekForward.
  • Improve seekToPrevious and seekToNext.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 2, 2025
@StaehliJ StaehliJ marked this pull request as ready for review April 3, 2025 14:05
@StaehliJ StaehliJ requested a review from MGaetan89 April 3, 2025 14:29
@MGaetan89 MGaetan89 linked an issue Apr 3, 2025 that may be closed by this pull request
Handle seek in time #952
Closed
MGaetan89
MGaetan89 approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@MGaetan89 MGaetan89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, and it seems to work fine.
I've tried audio, video, on a single device, and a group of devices, seeking back, forward, and in the current media.

Just have a look at the CI steps that are still broken.

@StaehliJ StaehliJ merged commit ae3af37 into 928-custom-castplayer Apr 9, 2025
8 of 10 checks passed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Apr 9, 2025
@StaehliJ StaehliJ deleted the 952-handle-seek branch April 9, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle seek in time

2 participants

@StaehliJ @MGaetan89