Skip to content

933 custom cast handle tracks#986

Merged
StaehliJ merged 14 commits into928-custom-castplayerfrom
933-custom-cast-handle-tracks
Apr 17, 2025
Merged

933 custom cast handle tracks#986
StaehliJ merged 14 commits into928-custom-castplayerfrom
933-custom-cast-handle-tracks

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Apr 11, 2025 •
edited
Loading

Pull request

Description

A tracks handle to PillarboxCastPlayer. Each cast MediaTrack are stored into a TrackGroup with a single Format. The TrackGroup.id is the MediaTrack.id so it is easy to select a track.

Changes made

  • Move some extensions to clean a bit PillarboxCastPlayer class.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 11, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 April 11, 2025 14:14
@MGaetan89 MGaetan89 linked an issue Apr 11, 2025 that may be closed by this pull request
Handle tracks #933
Closed
@github-actions
Copy link

github-actions bot commented Apr 14, 2025 •
edited
Loading

Code Coverage

Overall Project 48.71% -0.32% 🟢
Files changed 70.8% 🟢

Module Coverage
:pillarbox-cast 14.17% -3.55% 🟢
Kover Gradle Plugin XML report for :plugins 7.24% -0.2% 🟢
Files
Module File Coverage
:pillarbox-cast MediaTrack.kt 94.74% -5.26% 🟢
RemoteMediaClient.kt 86.64% -13.36% 🟢
PillarboxCastPlayer.kt 3.76% -3.6% 🟢
DefaultCastTrackSelector.kt 0% 🟢
PillarboxCastPlayerBuilder.kt 0% -1.2% 🟢
Kover Gradle Plugin XML report for :plugins PillarboxAndroidLibraryTestedModulePlugin.kt 0% -2.5% 🟢

MGaetan89
MGaetan89 reviewed Apr 15, 2025
View reviewed changes
StaehliJ and others added 3 commits April 15, 2025 17:17
@StaehliJ @MGaetan89
Update pillarbox-cast/src/test/java/ch/srgssr/pillarbox/cast/RemoteMe…
50a3f78 
…diaClientTest.kt

Co-authored-by: Gaëtan Muller <[email protected]>
@StaehliJ
Use orEmpty instead
471a9a9
@StaehliJ
Merge branch '928-custom-castplayer' into 933-custom-cast-handle-tracks
de77703 
# Conflicts:
#	pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt
@StaehliJ StaehliJ merged commit 3022b38 into 928-custom-castplayer Apr 17, 2025
9 of 10 checks passed
@StaehliJ StaehliJ deleted the 933-custom-cast-handle-tracks branch April 17, 2025 07:01
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle tracks

2 participants

@StaehliJ @MGaetan89