Make ParameterDiff detect changes to fx the Type of a PathParameter#22
Merged
Sayi merged 2 commits intoSayi:masterfrom Jun 29, 2020
Merged
Conversation
Pull Request Test Coverage Report for Build 63
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes to ParameterDiff and supporting class ListDiff to make the swagger-diff tool report when a parameter has been changed.
Example: Say a path parameter changes from type String to integer. This breaks backwards compatibility.
ListDiff change:
The ListDiff class previously attempted to remove elements from the 'increased' list using a call to equals. But since the two Parameters are not equal the element was not removed from the list (which it ought to be since the parameter is not new, only changed.
ParameterDiff change:
Previously the logic only handled BodyParameters.