Feature/GitHub remove org membership to free seat#65
Merged
betterclever merged 8 commits intomainfrom Nov 6, 2025
Merged
Conversation
9528d41 to
1e78082
Compare
66b4c70 to
427ac07
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces reusable 3rd‑party connection flow and a GitHub Connection Provider to pass connectionId downstream; worker retrieves tokens via POST /integrations/connections/:id/token guarded by INTERNAL_SERVICE_TOKEN (no tokens in UI).
Adds GitHub Remove Org Membership component to optionally remove from a team then the org; resolves email→username, emits progress, and treats 404s as idempotent “not found”.
Enables secure, repeatable GitHub offboarding/seat reclamation using a single OAuth connection shared across components.
Touched files: worker/src/components/github/connection-provider.ts, worker/src/components/github/remove-org-membership.ts, worker/src/components/index.ts, backend/src/integrations/integrations.controller.ts, backend/src/integrations/integrations.dto.ts
Testing
bun run test
bun run lint
bun run typecheck
Additional notes: E2E sanity — wire “GitHub Connection Provider” → “GitHub Remove Org Membership”; set organization, optional teamSlug, userIdentifier; ensure a GitHub connection exists; minimal scopes: admin:org read:org.