Skip to content

Add golden#1

Merged
SimonIT merged 1 commit intoSimonIT:CupertinoTextFieldfrom
LongCatIsLooong:add-golden-tests
Jun 1, 2019
Merged

Add golden#1
SimonIT merged 1 commit intoSimonIT:CupertinoTextFieldfrom
LongCatIsLooong:add-golden-tests

Conversation

@LongCatIsLooong
Copy link

Description

Related Issues

original PR: flutter#32974

Tests

  • disabled state golden

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@SimonIT SimonIT merged commit 0187056 into SimonIT:CupertinoTextField Jun 1, 2019
@LongCatIsLooong LongCatIsLooong deleted the add-golden-tests branch June 4, 2019 17:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants