Skip to content

Fix enchancement#1774

Closed
coco875 wants to merge 3 commits intoSinytra:1.21.xfrom
coco875:fix-enchancement
Closed

Fix enchancement#1774
coco875 wants to merge 3 commits intoSinytra:1.21.xfrom
coco875:fix-enchancement

Conversation

@coco875
Copy link

@coco875 coco875 commented Apr 11, 2025

The Issue

enchancement are incompatible

The Proposal

Make it compatible

Possible Side Effects

Some fabric mixin who use similar one as enchancement can conflict.

Alternatives

Make other patch ?.

Additional Notes

Make quick test and didn't have any crash, but the mod can have conflict with appleskin.

@ThePotatoArchivist
Copy link

I was hoping enchancement could be fixed on sinytra :)

Seems to be affected by the nonswimming bug affecting a few other mods #1343

@ThePotatoArchivist
Copy link

ThePotatoArchivist commented Apr 11, 2025

Also I crashed when a pillager shot a torch https://mclo.gs/Pv3abw4

@coco875
Copy link
Author

coco875 commented Apr 12, 2025

Also I crashed when a pillager shot a torch https://mclo.gs/Pv3abw4

fix this crash in latest commit, thanks for the report.

@Su5eD Su5eD mentioned this pull request Feb 4, 2026
@Su5eD Su5eD closed this in #2103 Feb 8, 2026
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Connector Triage Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants