Fix ConnectorCoremods creativeModeTabConstructorTransform#1802
Merged
Su5eD merged 1 commit intoSinytra:devfrom May 8, 2025
Merged
Fix ConnectorCoremods creativeModeTabConstructorTransform#1802Su5eD merged 1 commit intoSinytra:devfrom
Su5eD merged 1 commit intoSinytra:devfrom
Conversation
Signed-off-by: unilock <[email protected]>
Su5eD
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
The transformer in ConnectorCoremods that injected the vanilla CreativeModeTab constructor wasn't using the correct placeholder types to invoke the NeoForge CreativeModeTab constructor, causing a crash if any Fabric mod attempted to invoke the vanilla CreativeModeTab constructor directly
The Proposal
Adjust the placeholder types to invoke the NeoForge constructor properly
Possible Side Effects
None
Alternatives
None