Closed
Conversation
This was referenced Jan 23, 2024
Sjors
commented
Jan 23, 2024
src/node/sv2_template_provider.cpp
Outdated
Owner
Author
There was a problem hiding this comment.
This is also a bug fix, it was accidentally writing the static key into the authority key file.
Sjors
force-pushed
the
2024/01/sv2_autofile
branch
from
fbaf9a2 to
78e2705
Compare
Co-authored-by: Vasil Dimov <[email protected]>
This reverts commit 8b55be1.
Sjors
force-pushed
the
2024/01/sv2_autofile
branch
from
78e2705 to
147dc63
Compare
Owner
Author
|
I'm absorbing this into the main PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependency on bitcoin#29229.
Depends on bitcoin#29295
This also changes the serialisation format to include whether the key is compressed. Existing
sv2_static_keyandsv2_authority_keyfiles need to be removed from the datadir.