Allocate 8MB minimum to stack for new server threads#268
Merged
JohnSully merged 1 commit intoSnapchat:unstablefrom Dec 1, 2020
Merged
Allocate 8MB minimum to stack for new server threads#268JohnSully merged 1 commit intoSnapchat:unstablefrom
JohnSully merged 1 commit intoSnapchat:unstablefrom
Conversation
christianEQ
changed the title
Collaborator
|
Needs a description of the problem and what the fix accomplishes. Commit message needs to reference the issue being fixed. |
JohnSully
reviewed
Dec 1, 2020
src/server.cpp
Outdated
|
|
||
| pthread_attr_t tattr; | ||
| pthread_attr_init(&tattr); | ||
| pthread_attr_setstacksize(&tattr, 1 << 23); |
Collaborator
There was a problem hiding this comment.
Give a comment on the size in MB
christianEQ
force-pushed
the
thread_stacksize
branch
from
195495d to
8b9d17f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New server threads need reasonable memory for LZF compression's hash table. This will allocate 8MB minimum, which is the default on Ubuntu. Fixes #204.