Fix MangaUpdates WebLink to handle new url format#209
Conversation
Author
|
looks like |
Owner
|
Thanks for looking into this. |
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic used while adding aggregated MangaUpdates links to support both the existing
series.html?id={numeric_id}format (for both old and new numeric ids, this page redirects toseries/) and the newerseries/{hex_id}format (this alphanumeric id is hex encoded version of the new long numeric ids).I removed
encodeURLPath, which was unnecessarily encoding the?character inseries.html?id=part. Alsoidparameter in the oldseries.htmlurl only accepts numeric ids.Example valid URLs
https://www.mangaupdates.com/series/qzqpezyhttps://www.mangaupdates.com/series.html?id=58757512750How Komf added the urls before this change:
https://www.mangaupdates.com/series.html%3Fid=qzqpezy